Page MenuHomePhabricator

Straighten out reorder permissions on form configurations
ClosedPublic

Authored by epriestley on Dec 19 2015, 2:32 PM.

Details

Summary

Fixes T10012. The permissions here are little weird: you need edit permission on the configurations, not the engines. I was checking edit permission on the engines only.

I should possibly make this a bit more consistent, the engine edit permission is just very convenient to use to enforce object create permission right now. I'll likely clean this up after T9789.

Test Plan
  • Tried to reorder forms as a less-privileged user, got proper policy errors.
  • Reordered forms normally as a regular user.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 35839.Dec 19 2015, 2:32 PM
epriestley retitled this revision from to Straighten out reorder permissions on form configurations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Dec 19 2015, 3:33 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2015, 3:33 PM
This revision was automatically updated to reflect the committed changes.