Page MenuHomePhabricator

Straighten out reorder permissions on form configurations
ClosedPublic

Authored by epriestley on Dec 19 2015, 2:32 PM.
Tags
None
Referenced Files
F14058948: D14824.diff
Sun, Nov 17, 4:11 PM
F14048488: D14824.diff
Thu, Nov 14, 7:55 AM
F14034064: D14824.diff
Sat, Nov 9, 9:58 PM
F14021770: D14824.diff
Wed, Nov 6, 12:01 PM
F14001299: D14824.id35840.diff
Fri, Oct 25, 6:11 AM
F13986348: D14824.diff
Mon, Oct 21, 2:16 AM
F13985450: D14824.id35839.diff
Sun, Oct 20, 8:33 PM
F13972406: D14824.id.diff
Oct 17 2024, 6:49 PM
Subscribers

Details

Summary

Fixes T10012. The permissions here are little weird: you need edit permission on the configurations, not the engines. I was checking edit permission on the engines only.

I should possibly make this a bit more consistent, the engine edit permission is just very convenient to use to enforce object create permission right now. I'll likely clean this up after T9789.

Test Plan
  • Tried to reorder forms as a less-privileged user, got proper policy errors.
  • Reordered forms normally as a regular user.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Straighten out reorder permissions on form configurations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2015, 3:33 PM
This revision was automatically updated to reflect the committed changes.