Page MenuHomePhabricator

Straighten out reorder permissions on form configurations
ClosedPublic

Authored by epriestley on Dec 19 2015, 2:32 PM.
Tags
None
Referenced Files
F13087263: D14824.diff
Thu, Apr 25, 12:55 AM
Unknown Object (File)
Sun, Apr 14, 3:23 PM
Unknown Object (File)
Thu, Apr 11, 8:41 AM
Unknown Object (File)
Fri, Mar 29, 9:48 AM
Unknown Object (File)
Mar 15 2024, 7:23 AM
Unknown Object (File)
Mar 5 2024, 3:40 PM
Unknown Object (File)
Feb 14 2024, 8:55 PM
Unknown Object (File)
Feb 14 2024, 8:54 PM
Subscribers

Details

Summary

Fixes T10012. The permissions here are little weird: you need edit permission on the configurations, not the engines. I was checking edit permission on the engines only.

I should possibly make this a bit more consistent, the engine edit permission is just very convenient to use to enforce object create permission right now. I'll likely clean this up after T9789.

Test Plan
  • Tried to reorder forms as a less-privileged user, got proper policy errors.
  • Reordered forms normally as a regular user.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Straighten out reorder permissions on form configurations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2015, 3:33 PM
This revision was automatically updated to reflect the committed changes.