Page MenuHomePhabricator

Have "limit=1" tokenizers replace tokens instead of disabling "Browse"
ClosedPublic

Authored by epriestley on Dec 14 2015, 10:53 PM.
Tags
None
Referenced Files
F18090223: D14785.id35748.diff
Wed, Aug 6, 2:54 PM
F18085486: D14785.diff
Tue, Aug 5, 7:15 PM
F18075514: D14785.id35754.diff
Mon, Aug 4, 6:09 PM
F17947471: D14785.id.diff
Thu, Jul 31, 4:49 PM
F17927965: D14785.diff
Wed, Jul 30, 3:30 PM
Unknown Object (File)
Jun 30 2025, 1:43 PM
Unknown Object (File)
Jun 28 2025, 3:04 PM
Unknown Object (File)
May 30 2025, 10:37 AM
Subscribers
None

Details

Summary

Fixes T9984. When a tokenizer only allows one selection (like "Task Owner:" or "Land Onto Branch:"), keep the browse button active but have it replace values.

Also, have "Create Subtask" default to the system default status, so subtasks of closed tasks are not also closed.

Test Plan
  • Browsed an empty limit=1 tokenizer.
  • Replaced a full limit=1 tokenizer.
  • Browsed an empty no-limit tokenizer.
  • Browsed more tokens into the no-limit tokenizer.
  • Typed some tokens normally.
  • Created a subtask of a closed task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Have "limit=1" tokenizers replace tokens instead of disabling "Browse".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2015, 11:18 PM
This revision was automatically updated to reflect the committed changes.