Differential D14594

Don't raise setup warning for "bad version" if the binary is not there
ClosedPublic
Actions

Authored by avivey on Nov 29 2015, 12:21 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPf6c98a55a4ed: Don't raise setup warning for "bad version" if the binary is not there

Test Plan

warning is not in warnings list.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9115
Build 10745: Run Core Tests
Build 10744: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 35304.Nov 29 2015, 12:21 AM

avivey retitled this revision from to Don't raise setup warning for "bad version" if the binary is not there.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey set the repository for this revision to rP Phabricator.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 29 2015, 12:21 AM

Herald added a subscriber: epriestley. · View Herald Transcript

avivey added inline comments.Nov 29 2015, 12:22 AM

src/applications/config/check/PhabricatorBinariesSetupCheck.php
103	This is slightly more precise, but probably will always be exactly the same.

epriestley accepted this revision.Nov 29 2015, 12:51 AM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Nov 29 2015, 12:51 AM

Closed by commit rPf6c98a55a4ed: Don't raise setup warning for "bad version" if the binary is not there (authored by avivey, committed by avivey). · Explain WhyNov 29 2015, 11:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorBinariesSetupCheck.php

3 lines

Diff 35304

View Options

src/applications/config/check/PhabricatorBinariesSetupCheck.php

Don't raise setup warning for "bad version" if the binary is not thereClosedPublicActions