Page MenuHomePhabricator

Implement PhabricatorDestructibleInterface in Phame
ClosedPublic

Authored by chad on Nov 28 2015, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:21 AM
Unknown Object (File)
Mon, Apr 1, 9:59 AM
Unknown Object (File)
Mon, Apr 1, 2:58 AM
Unknown Object (File)
Mar 7 2024, 4:57 PM
Unknown Object (File)
Mar 5 2024, 2:27 AM
Unknown Object (File)
Mar 5 2024, 2:27 AM
Unknown Object (File)
Mar 5 2024, 2:27 AM
Unknown Object (File)
Feb 18 2024, 10:31 AM
Subscribers

Details

Summary

Allows Blogs and Posts to be destroyed. Fixes T9756

Test Plan

Test bin/remove destroy POST and bin/remove destroy BLOG to great success.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Implement PhabricatorDestructibleInterface in Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Build failure looks like a missing arc liberate. Couple o' inlines.

src/applications/phame/storage/PhameBlog.php
331–332

You don't need this, $this is the same as $blog.

src/applications/phame/storage/PhamePost.php
262–263

You can get rid of this, it's unused and $this->delete() always does the same thing anyway.

This revision is now accepted and ready to land.Nov 28 2015, 8:00 PM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • Updates
This revision was automatically updated to reflect the committed changes.