Page MenuHomePhabricator
Differential D14586

Implement PhabricatorDestructibleInterface in Phame
ClosedPublic
Actions

Authored by chad on Nov 28 2015, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 7:14 AM
Unknown Object (File)
Sat, Dec 7, 11:16 AM
Unknown Object (File)
Mon, Dec 2, 11:20 PM
Unknown Object (File)
Mon, Dec 2, 11:20 PM
Unknown Object (File)
Mon, Dec 2, 11:19 PM
Unknown Object (File)
Sat, Nov 30, 3:18 PM
Unknown Object (File)
Sun, Nov 24, 5:56 PM
Unknown Object (File)
Sun, Nov 24, 1:37 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9756: Allow Blogs and Posts to be archived
Commits
Restricted Diffusion Commit
rPe8a39ca3e5f0: Implement PhabricatorDestructibleInterface in Phame
Summary

Allows Blogs and Posts to be destroyed. Fixes T9756

Test Plan

Test bin/remove destroy POST and bin/remove destroy BLOG to great success.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35287.Nov 28 2015, 7:12 PM
chad retitled this revision from to Implement PhabricatorDestructibleInterface in Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9756: Allow Blogs and Posts to be archived.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 28 2015, 7:12 PM
chad edited the test plan for this revision. (Show Details)Nov 28 2015, 7:13 PM
epriestley accepted this revision.Nov 28 2015, 8:00 PM
epriestley edited edge metadata.

Build failure looks like a missing arc liberate. Couple o' inlines.

src/applications/phame/storage/PhameBlog.php
331–332

You don't need this, $this is the same as $blog.

src/applications/phame/storage/PhamePost.php
262–263

You can get rid of this, it's unused and $this->delete() always does the same thing anyway.

This revision is now accepted and ready to land.Nov 28 2015, 8:00 PM
chad updated this revision to Diff 35289.Nov 28 2015, 9:02 PM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • Updates
Closed by commit rPe8a39ca3e5f0: Implement PhabricatorDestructibleInterface in Phame (authored by chad, committed by chad). · Explain WhyNov 28 2015, 9:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
phame/
storage/
18 lines
13 lines

Diff 35290

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/storage/PhameBlog.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility