Page MenuHomePhabricator

Render Remarkup in emails
ClosedPublic

Authored by joshuaspence on Nov 18 2015, 8:52 PM.
Tags
None
Referenced Files
F10772059: D14511.id.diff
Sat, May 28, 2:31 PM
Unknown Object (File)
Mon, May 23, 2:05 PM
Unknown Object (File)
Apr 14 2017, 8:50 AM
Unknown Object (File)
Apr 8 2017, 7:38 PM
Unknown Object (File)
Mar 20 2017, 12:26 PM
Unknown Object (File)
Feb 22 2017, 9:37 AM
Unknown Object (File)
Feb 4 2017, 9:22 PM
Unknown Object (File)
Jan 14 2017, 1:18 PM
Subscribers

Details

Summary

Ref T992. I noticed that ManiphestTask mail doesn't render Remarkup properly (instead, it renders Remarkup literally). I think this is because the code calls addTextSection() rather than addRemarkupSection().

Test Plan

Created a new Maniphest Task and saw Remarkup in the generated self-email (inspect the email contents with ./bin/mail show-outbound). I didn't test the other affected applications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Render Remarkup in emails.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 3:29 PM
This revision was automatically updated to reflect the committed changes.