Page MenuHomePhabricator
Differential D14489

Use Remarkup in linter messages
ClosedPublic
Actions

Authored by joshuaspence on Nov 15 2015, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 6, 3:02 PM
Unknown Object (File)
Apr 28 2025, 4:24 AM
Unknown Object (File)
Apr 28 2025, 4:24 AM
Unknown Object (File)
Apr 28 2025, 4:22 AM
Unknown Object (File)
Apr 20 2025, 3:53 PM
Unknown Object (File)
Apr 20 2025, 3:17 PM
Unknown Object (File)
Apr 20 2025, 3:17 PM
Unknown Object (File)
Apr 12 2025, 1:53 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC3b41e62f8700: Use Remarkup in linter messages
Summary

Use Remarkup (specifically, backticks) within linter messages. Depends on D14485.

Test Plan

Eyeball it.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8861
Build 10360: Run Core Tests
Build 10359: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
542 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
11 msArcanistRubyLinterTestCase::Unknown Unit Message ("")
23 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
15 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
19 msArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (2 Failed · 259 Passed · 48 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35051.Nov 15 2015, 8:06 PM
joshuaspence retitled this revision from to Use Remarkup in linter messages.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D14485: Allow lint messages to be rendered as Remarkup.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2015, 8:06 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 23 2015, 3:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 3:29 PM
Closed by commit rARC3b41e62f8700: Use Remarkup in linter messages (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 23 2015, 7:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
6 lines
6 lines
2 lines
2 lines
5 lines
8 lines
6 lines
7 lines
6 lines
6 lines
2 lines
7 lines
12 lines
4 lines
9 lines
12 lines
4 lines
8 lines
38 lines
4 lines
2 lines
6 lines
6 lines
4 lines
4 lines
6 lines
5 lines
6 lines
6 lines
2 lines
16 lines
2 lines
4 lines
2 lines
4 lines

Diff 35051

View Options

src/lint/linter/xhpast/rules/ArcanistArrayCombineXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClassExtendsObjectXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClassFilenameMismatchXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistCommentStyleXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistDeclarationParenthesesXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistDynamicDefineXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistElseIfUsageXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistExitExpressionXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistExtractUseXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistFormattedStringXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistImplicitConstructorXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistImplicitFallthroughXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistInstanceOfOperatorXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistInvalidDefaultParameterXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistInvalidModifiersXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistKeywordCasingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistLambdaFuncFunctionXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistNamingConventionsXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistNoParentScopeXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPHPCloseTagXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPHPEchoTagXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPHPOpenTagXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPHPShortTagXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistParseStrUseXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPlusOperatorOnStringsXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPregQuoteMisuseXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistRaggedClassTreeEdgeXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistReusedIteratorReferenceXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistSlownessXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistStaticThisXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistToStringExceptionXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility