Page MenuHomePhabricator
Differential D14426

Add mail/feed support to PhamePost
ClosedPublic
Actions

Authored by chad on Nov 6 2015, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 3:50 AM
Unknown Object (File)
Sat, Feb 8, 11:43 PM
Unknown Object (File)
Mon, Feb 3, 8:51 PM
Unknown Object (File)
Mon, Jan 27, 7:09 PM
Unknown Object (File)
Mon, Jan 27, 7:09 PM
Unknown Object (File)
Mon, Jan 27, 7:09 PM
Unknown Object (File)
Mon, Jan 27, 7:09 PM
Unknown Object (File)
Mon, Jan 27, 7:09 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
Restricted Diffusion Commit
rP6fe2377cc2c5: Add mail/feed support to PhamePost
Summary

Allows feed stories and mail for new Phame Posts.

Test Plan

Write Post, Get Mail

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34853.Nov 6 2015, 9:48 PM
chad retitled this revision from to Add mail/feed support to PhamePost.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 6 2015, 9:48 PM
chad updated this revision to Diff 34855.Nov 6 2015, 10:16 PM
  • fixors
chad planned changes to this revision.Nov 6 2015, 10:17 PM

I have mail and feed working, so going to polish it up a bit and re-submit.

chad updated this revision to Diff 34859.Nov 7 2015, 1:13 AM
  • fixors
  • check isDraft
  • Include BODY in new Phame Posts
chad updated this object.Nov 7 2015, 1:14 AM
chad added inline comments.Nov 7 2015, 1:18 AM
src/applications/phame/editor/PhamePostEditor.php
152–155

Will follow up on next diff, but by default all new posts are "drafts" and there is no transaction for "publish". I hard coded testing emails and feed stories.

I plan to default new posts to "published" and add a transaction type for visibility changes.

epriestley accepted this revision.Nov 7 2015, 1:34 AM
epriestley edited edge metadata.

Couple minor inlines.

src/applications/phame/editor/PhamePostEditor.php
172

Just getBlogPHID(), not getBlogPHID($object) I think?

174

For clarity, these are $phids, not $ids.

187

Or just setSubject($title).

188

Maybe just use the PHID? I think we've generally been doing that in the more recent stuff.

This revision is now accepted and ready to land.Nov 7 2015, 1:34 AM
chad updated this revision to Diff 34860.Nov 7 2015, 1:41 AM
chad marked 5 inline comments as done.
chad edited edge metadata.
  • per comments
Closed by commit rP6fe2377cc2c5: Add mail/feed support to PhamePost (authored by chad, committed by chad). · Explain WhyNov 7 2015, 1:43 AM
This revision was automatically updated to reflect the committed changes.
chad added a task: T9360: Unbeta Phame.Nov 7 2015, 1:44 AM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
18 lines
src/
2 lines
applications/
phame/
editor/
2 lines
67 lines
mail/
21 lines
storage/
9 lines
62 lines

Diff 34861

View Options

resources/sql/autopatches/20151106.phame.post.mailkey.1.sql

Loading...
View Options

resources/sql/autopatches/20151106.phame.post.mailkey.2.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditor.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/mail/PhamePostReplyHandler.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phame/storage/PhamePostTransaction.php

Loading...
Phabricator · Built by Phacility