Page MenuHomePhabricator

Add mail/feed support to PhamePost
ClosedPublic

Authored by chad on Nov 6 2015, 9:48 PM.

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
Restricted Diffusion Commit
rP6fe2377cc2c5: Add mail/feed support to PhamePost
Summary

Allows feed stories and mail for new Phame Posts.

Test Plan

Write Post, Get Mail

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add mail/feed support to PhamePost.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad planned changes to this revision.Nov 6 2015, 10:17 PM

I have mail and feed working, so going to polish it up a bit and re-submit.

  • fixors
  • check isDraft
  • Include BODY in new Phame Posts
src/applications/phame/editor/PhamePostEditor.php
152–155

Will follow up on next diff, but by default all new posts are "drafts" and there is no transaction for "publish". I hard coded testing emails and feed stories.

I plan to default new posts to "published" and add a transaction type for visibility changes.

epriestley edited edge metadata.

Couple minor inlines.

src/applications/phame/editor/PhamePostEditor.php
172

Just getBlogPHID(), not getBlogPHID($object) I think?

174

For clarity, these are $phids, not $ids.

187

Or just setSubject($title).

188

Maybe just use the PHID? I think we've generally been doing that in the more recent stuff.

This revision is now accepted and ready to land.Nov 7 2015, 1:34 AM
chad marked 5 inline comments as done.
chad edited edge metadata.
  • per comments
This revision was automatically updated to reflect the committed changes.