Page MenuHomePhabricator
Differential D14373

Set `$can_edit` for Harbormaster steps
ClosedPublic
Actions

Authored by joshuaspence on Oct 31 2015, 12:22 AM.
Tags
None
Referenced Files
F15437911: D14373.diff
Tue, Mar 25, 10:06 PM
F15436931: D14373.id34701.diff
Tue, Mar 25, 4:48 PM
F15430395: D14373.diff
Mon, Mar 24, 7:27 AM
F15416049: D14373.id34701.diff
Thu, Mar 20, 8:55 AM
F15378898: D14373.id34701.diff
Thu, Mar 13, 5:35 PM
F15332191: D14373.id34701.diff
Fri, Mar 7, 4:47 PM
Unknown Object (File)
Sun, Mar 2, 3:40 PM
Unknown Object (File)
Feb 21 2025, 3:53 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP98a301a59b1d: Set `$can_edit` for Harbormaster steps
Summary

Sets the $can_edit value correctly (previously it was hardcoded to true).

Test Plan

Went to http://phabricator.local/harbormaster/step/view/1/ and saw "Edit Step" disabled.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 34700.Oct 31 2015, 12:22 AM
joshuaspence retitled this revision from to Set `$can_edit` for Harbormaster steps.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 31 2015, 12:22 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Oct 31 2015, 1:45 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2015, 1:45 AM
Closed by commit rP98a301a59b1d: Set `$can_edit` for Harbormaster steps (authored by joshuaspence, committed by joshuaspence). · Explain WhyOct 31 2015, 4:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
5 lines

Diff 34701

View Options

src/applications/harbormaster/controller/HarbormasterStepViewController.php

Loading...
Phabricator · Built by Phacility