Page MenuHomePhabricator

Set `$can_edit` for Harbormaster steps
ClosedPublic

Authored by joshuaspence on Oct 31 2015, 12:22 AM.
Tags
None
Referenced Files
F15378898: D14373.id34701.diff
Thu, Mar 13, 5:35 PM
F15332191: D14373.id34701.diff
Fri, Mar 7, 4:47 PM
Unknown Object (File)
Sun, Mar 2, 3:40 PM
Unknown Object (File)
Fri, Feb 21, 3:53 PM
Unknown Object (File)
Fri, Feb 14, 3:48 AM
Unknown Object (File)
Feb 8 2025, 11:38 PM
Unknown Object (File)
Feb 6 2025, 5:15 AM
Unknown Object (File)
Jan 31 2025, 9:22 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP98a301a59b1d: Set `$can_edit` for Harbormaster steps
Summary

Sets the $can_edit value correctly (previously it was hardcoded to true).

Test Plan

Went to http://phabricator.local/harbormaster/step/view/1/ and saw "Edit Step" disabled.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Set `$can_edit` for Harbormaster steps.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2015, 1:45 AM
This revision was automatically updated to reflect the committed changes.