Page MenuHomePhabricator
Differential D14351

Fix landing icon
ClosedPublic
Actions

Authored by chad on Oct 27 2015, 7:00 PM.

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP4b5de5135c29: Fix landing icon
Summary

This is hilarious.

Test Plan

Test icon on local install.

Diff Detail

Repository
rP Phabricator
Branch
lolz
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 8451
Build 9721: Run Core Tests
Build 9720: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34643.Oct 27 2015, 7:00 PM
chad retitled this revision from to Fix landing icon.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 27 2015, 7:00 PM
chad added a comment.Oct 27 2015, 7:01 PM

I'm guessing this is too specific an icon for Drydock.

epriestley accepted this revision.Oct 27 2015, 7:01 PM
epriestley edited edge metadata.

:D :D :D

This revision is now accepted and ready to land.Oct 27 2015, 7:01 PM
epriestley added a comment.Oct 27 2015, 7:02 PM

We can pick some more general icon if it's confusing once Drydock does more stuff here.

chad added a comment.Oct 27 2015, 7:02 PM

Can't seem to land it lolz, still says "under review"

epriestley added a comment.Oct 27 2015, 7:02 PM

Oh haha

Closed by commit rP4b5de5135c29: Fix landing icon (authored by chad). · Explain WhyOct 27 2015, 7:07 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Oct 27 2015, 7:07 PM

pushing!!!!!

epriestley mentioned this in Blog Post: Development Notes (2015 Week 44).Nov 2 2015, 5:28 PM

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
storage/
2 lines

Diff 34643

View Options

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...
Phabricator · Built by Phacility