Set a property so that unit tests run on PHP7
ClosedPublic
Actions

Authored by Mnkras on Oct 26 2015, 7:34 PM.

Tags

None

Referenced Files

	F15533888: D14345.id.diff
	Wed, Apr 23, 10:41 PM

	F15522087: D14345.id.diff
	Sun, Apr 20, 6:04 PM

	F15521670: D14345.id34633.diff
	Sun, Apr 20, 3:38 PM

	F15521668: D14345.id34618.diff
	Sun, Apr 20, 3:38 PM

	F15521667: D14345.diff
	Sun, Apr 20, 3:38 PM

	F15518982: D14345.id34633.diff
	Sat, Apr 19, 6:41 PM

	F15513190: D14345.id.diff
	Thu, Apr 17, 5:09 PM

	F15509314: D14345.diff
	Wed, Apr 16, 11:10 AM

View All Files

Subscribers

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9640: Make Phabricator compatible with PHP7

Commits

Restricted Diffusion Commit
rP6e7ceb996bb3: Set a property so that unit tests run on PHP7

Summary

Without this change PHP throws because idx() is passed null as the property is not intialzied

Test Plan

arc unit --everything

Diff Detail

Repository

rP Phabricator

Branch

php7-unit

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8427
Build 9686: arc lint + arc unit

Event Timeline

Mnkras updated this revision to Diff 34618.Oct 26 2015, 7:34 PM

Mnkras retitled this revision from to Set a property so that unit tests run on PHP7.

Mnkras updated this object.

Mnkras edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 26 2015, 7:34 PM

Herald added a subscriber: epriestley. · View Herald Transcript

If you hold this for a bit you can try "Land Revision".

This revision is now accepted and ready to land.Oct 26 2015, 7:38 PM

Closed by commit rP6e7ceb996bb3: Set a property so that unit tests run on PHP7 (authored by Mnkras, committed by Mnkras). · Explain WhyOct 26 2015, 9:15 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a task: T9640: Make Phabricator compatible with PHP7.Oct 27 2015, 8:22 AM

Revision Contents
Changeset List

Path

Size

src/

aphront/

AphrontRequest.php

2 lines

Diff 34618

View Options

src/aphront/AphrontRequest.php

Set a property so that unit tests run on PHP7ClosedPublicActions