Page MenuHomePhabricator
Differential D14314

Show a more reasonable status element for pull requests
ClosedPublic
Actions

Authored by epriestley on Oct 20 2015, 11:31 PM.
Tags
None
Referenced Files
F15539886: D14314.id34552.diff
Fri, Apr 25, 5:45 AM
F15526014: D14314.id34552.diff
Mon, Apr 21, 6:35 PM
F15524522: D14314.id34556.diff
Mon, Apr 21, 8:38 AM
F15515038: D14314.id34556.diff
Fri, Apr 18, 7:24 AM
F15512831: D14314.diff
Thu, Apr 17, 2:20 PM
F15511985: D14314.id.diff
Thu, Apr 17, 7:10 AM
F15511850: D14314.id.diff
Thu, Apr 17, 5:48 AM
F15511519: D14314.diff
Thu, Apr 17, 2:45 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T182: Commit into repository directly from differential
Commits
Restricted Diffusion Commit
rP5b619862cb06: Show a more reasonable status element for pull requests
Summary

Ref T182. Replace the total mess we had before with a sort-of-reasonable element.

This automatically updates using "javascript".

Test Plan

Screen Shot 2015-10-20 at 4.05.54 PM.png (725×1 px, 132 KB)

Screen Shot 2015-10-20 at 4.28.50 PM.png (871×1 px, 141 KB)

Used "Land Revision", saw the land status go from "Waiting" -> "Working" -> "Landed" without having to mash reload over and over again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34552.Oct 20 2015, 11:31 PM
epriestley retitled this revision from to Show a more reasonable status element for pull requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T182: Commit into repository directly from differential.
chad accepted this revision.Oct 21 2015, 12:47 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 21 2015, 12:47 AM
Closed by commit rP5b619862cb06: Show a more reasonable status element for pull requests (authored by epriestley, committed by epriestley). · Explain WhyOct 21 2015, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
7 lines
src/
4 lines
applications/
differential/
controller/
29 lines
drydock/
application/
1 line
controller/
59 lines
operation/
24 lines
4 lines
storage/
16 lines
view/
84 lines
webroot/
rsrc/
js/
application/
drydock/
32 lines

Diff 34556

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Loading...
View Options

src/applications/drydock/controller/DrydockRepositoryOperationStatusController.php

Loading...
View Options

src/applications/drydock/operation/DrydockLandRepositoryOperation.php

Loading...
View Options

src/applications/drydock/operation/DrydockRepositoryOperationType.php

Loading...
View Options

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...
View Options

src/applications/drydock/view/DrydockRepositoryOperationStatusView.php

Loading...
View Options

webroot/rsrc/js/application/drydock/drydock-live-operation-status.js

Loading...
Phabricator · Built by Phacility