Page MenuHomePhabricator
Differential D14304

Don't allow logged out users to initialize a Workboard
ClosedPublic
Actions

Authored by chad on Oct 19 2015, 7:02 PM.
Tags
None
Referenced Files
F13173719: D14304.diff
Tue, May 7, 8:46 PM
Unknown Object (File)
Mon, May 6, 9:50 PM
Unknown Object (File)
Sat, May 4, 6:29 AM
Unknown Object (File)
Wed, May 1, 1:00 AM
Unknown Object (File)
Sun, Apr 28, 8:31 PM
Unknown Object (File)
Sun, Apr 28, 1:52 PM
Unknown Object (File)
Sun, Apr 28, 12:29 PM
Unknown Object (File)
Sun, Apr 28, 3:18 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)"
Commits
Restricted Diffusion Commit
rP267e718dfe2f: Don't allow logged out users to initialize a Workboard
Summary

Right now logged out users can enable a workboard on a project.

Test Plan

Log out, view a public project, click on Workboard, get not set up dialog. Click Cancel, return to project details.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34526.Oct 19 2015, 7:02 PM
chad retitled this revision from to Don't allow logged out users to initialize a Workboard.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 19 2015, 7:02 PM
epriestley accepted this revision.Oct 19 2015, 7:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2015, 7:03 PM
Closed by commit rP267e718dfe2f: Don't allow logged out users to initialize a Workboard (authored by chad, committed by chad). · Explain WhyOct 19 2015, 7:12 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Oct 19 2015, 7:33 PM

Oh, I guess this should be can_edit

epriestley added a comment.Oct 19 2015, 8:15 PM

Probably some new permission after T6502, you could maybe just leave it as is until we get there since that's maybe-in-theory some time this year.

chad added a task: T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".Oct 19 2015, 8:22 PM

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
17 lines

Diff 34527

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
Phabricator · Built by Phacility