Pass author config to `git` with "-c x=y" instead of "--author"
ClosedPublic
Actions

Authored by epriestley on Oct 4 2015, 3:48 PM.

Details

Reviewers

Commits

rARC1773aad85599: (stable) Promote 2015 Week 41
rARC172c930630a9: Pass author config to `git` with "-c x=y" instead of "--author"

Summary

See D14232. That didn't actually work. It looks like this does.

Test Plan

Ran git commit --author ... on build server and saw the same failure.
Ran git -c ... -c ... commit ... on build server and saw it work.

Diff Detail

Repository

rARC Arcanist

Branch

unit4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8180
Build 9348: Run Core Tests
Build 9347: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34369.Oct 4 2015, 3:48 PM

epriestley retitled this revision from to Pass author config to `git` with "-c x=y" instead of "--author".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

shipitquick

This revision is now accepted and ready to land.Oct 4 2015, 3:49 PM

This one got a clean build on the server side, too:

https://secure.phabricator.com/harbormaster/build/9348/

Closed by commit rARC172c930630a9: Pass author config to `git` with "-c x=y" instead of "--author" (authored by epriestley, committed by epriestley). · Explain WhyOct 4 2015, 3:49 PM

This revision was automatically updated to reflect the committed changes.

Screen Shot 2015-10-04 at 8.55.32 AM.png (228×261 px, 26 KB)

Revision Contents
Changeset List

Path

Size

src/

parser/

__tests__/

ArcanistBundleTestCase.php

12 lines

Diff 34369

View Options

src/parser/tests/ArcanistBundleTestCase.php

Pass author config to `git` with "-c x=y" instead of "--author"ClosedPublicActions