Page MenuHomePhabricator

Set Korean PLURAL rules to singular only.
AbandonedPublic

Authored by revi on Oct 3 2015, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 3:08 PM
Unknown Object (File)
Mon, Nov 25, 2:48 PM
Unknown Object (File)
Sat, Nov 23, 12:51 PM
Unknown Object (File)
Tue, Nov 19, 12:56 AM
Unknown Object (File)
Thu, Nov 14, 9:26 PM
Unknown Object (File)
Thu, Nov 14, 6:05 PM
Unknown Object (File)
Mon, Nov 11, 4:00 PM
Unknown Object (File)
Fri, Nov 8, 8:37 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

After some discussions about D14228 with other folks doing translation with me, we have decided that it would be better without plural. TBH I'm not sure if this is correct way to enforce singular only.

Test Plan
  • Make sure singular and plural form somewhere at least one string is different so you can check if patch is cleanly done
  • Apply patch
  • Check the string back and see if you see singular where you saw plural.

Diff Detail

Repository
rPHU libphutil
Branch
ko-singularonly
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8172
Build 9335: arc lint + arc unit

Event Timeline

revi retitled this revision from to Set Korean PLURAL rules to singular only..
revi updated this object.
revi edited the test plan for this revision. (Show Details)
revi added reviewers: Blessed Reviewers, epriestley.
revi added a subscriber: Korvin.
revi planned changes to this revision.Oct 3 2015, 6:00 PM

Err, was meant to mark --preview...... Duh.

revi edited edge metadata.

remove $plural

Well, since my stupid forgetting --preview made this effect, just leaving update here.

Since I removed $plural usage earlier, remove it as well from list.</night>

revi edited the test plan for this revision. (Show Details)

Will resubmit later.