Page MenuHomePhabricator
Differential D14212

Improve error and exception handling for Drydock leases
ClosedPublic
Actions

Authored by epriestley on Oct 1 2015, 12:57 PM.
Tags
None
Referenced Files
F14411654: D14212.diff
Tue, Dec 24, 11:59 AM
F14407113: D14212.id34322.diff
Tue, Dec 24, 1:49 AM
Unknown Object (File)
Sat, Dec 21, 10:48 AM
Unknown Object (File)
Fri, Dec 20, 5:24 PM
Unknown Object (File)
Wed, Dec 18, 3:56 AM
Unknown Object (File)
Mon, Dec 16, 10:38 AM
Unknown Object (File)
Tue, Dec 10, 6:00 PM
Unknown Object (File)
Sun, Dec 8, 10:29 PM
View All Files
Subscribers
None

Details

Reviewers
hach-que
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rPb219bcfb3d70: Improve error and exception handling for Drydock leases
Summary

Ref T9252. See companion change in D14211. This does the same thing for leases.

Particularly, most of the TODOs about error handling can just be removed because they'll do the right things by default now.

This and D14211 also move slot lock release to after resource destruction. This feels cleaner than trying to release early at release/break.

Test Plan

Restarted a Harbormaster build, got a clean build result. This needs more vetting but I'll clean up any issues as I hit them.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34313.Oct 1 2015, 12:57 PM
epriestley retitled this revision from to Improve error and exception handling for Drydock leases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
epriestley added a task: T9252: Unprototype Drydock (v1).
hach-que accepted this revision.Oct 1 2015, 12:59 PM
hach-que edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2015, 12:59 PM
epriestley mentioned this in D10409: [drydock/core] Mark leases as broken when failing to acquiring lease.Oct 1 2015, 2:35 PM
epriestley mentioned this in D10504: [drydock/core] Add more logging around why leases are broken.Oct 1 2015, 2:42 PM
Closed by commit rPb219bcfb3d70: Improve error and exception handling for Drydock leases (authored by epriestley, committed by epriestley). · Explain WhyOct 1 2015, 3:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
worker/
117 lines

Diff 34322

View Options

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

Loading...
Phabricator · Built by Phacility