Page MenuHomePhabricator

Improve error and exception handling for Drydock leases
ClosedPublic

Authored by epriestley on Oct 1 2015, 12:57 PM.
Tags
None
Referenced Files
F14024176: D14212.diff
Thu, Nov 7, 6:50 AM
F13983602: D14212.id34313.diff
Sun, Oct 20, 7:30 AM
Unknown Object (File)
Oct 7 2024, 6:29 AM
Unknown Object (File)
Oct 2 2024, 5:47 PM
Unknown Object (File)
Oct 2 2024, 5:46 PM
Unknown Object (File)
Sep 30 2024, 6:41 PM
Unknown Object (File)
Sep 27 2024, 12:30 PM
Unknown Object (File)
Sep 20 2024, 7:41 AM
Subscribers
None

Details

Summary

Ref T9252. See companion change in D14211. This does the same thing for leases.

Particularly, most of the TODOs about error handling can just be removed because they'll do the right things by default now.

This and D14211 also move slot lock release to after resource destruction. This feels cleaner than trying to release early at release/break.

Test Plan

Restarted a Harbormaster build, got a clean build result. This needs more vetting but I'll clean up any issues as I hit them.

Diff Detail

Repository
rP Phabricator
Branch
dd13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8121
Build 9266: [Placeholder Plan] Wait for 30 Seconds
Build 9265: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve error and exception handling for Drydock leases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
hach-que edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2015, 12:59 PM
This revision was automatically updated to reflect the committed changes.