Page MenuHomePhabricator

Move Drydock logs to PHIDs and increased structure
ClosedPublic

Authored by epriestley on Sep 30 2015, 2:43 PM.
Tags
None
Referenced Files
F14061015: D14196.id34315.diff
Mon, Nov 18, 4:40 AM
F14057743: D14196.diff
Sun, Nov 17, 6:26 AM
F14033430: D14196.id34291.diff
Sat, Nov 9, 5:38 PM
F14008041: D14196.id34315.diff
Tue, Oct 29, 2:38 PM
F14005133: D14196.id.diff
Sun, Oct 27, 7:48 AM
F13998768: D14196.diff
Thu, Oct 24, 11:04 AM
F13997223: D14196.id34291.diff
Thu, Oct 24, 3:04 AM
F13988831: D14196.diff
Mon, Oct 21, 4:15 PM
Subscribers
None

Details

Summary

Ref T9252. Several general changes here:

  • Moves logs to use PHIDs instead of IDs. This generally improves flexibility (for example, it's a lot easier to render handles).
  • Adds blueprintPHID to logs. Although you can usually figure this out from the leasePHID or resourcePHID, it lets us query relevant logs on Blueprint views.
  • Instead of making logs a top-level object, make them strictly a sub-object of Blueprints, Resources and Leases. So you go Drydock > Lease > Logs, etc., to get to logs.
    • I might restore the "everything" view eventually, but it doesn't interact well with policies and I'm not sure it's very useful. A policy-violating bin/drydock log might be cleaner.
  • Policy-wise, we always show you that logs exist, we just don't show you log content if it's about something you can't see. This is similar to seeing restricted handles in other applications.
  • Instead of just having a message, give logs "type" + "data". This will let logs be more structured and translatable. This is similar to recent changes to Herald which seem to have worked well.
Test Plan

Added some placeholder log writes, viewed those logs in the UI.

Screen Shot 2015-09-30 at 7.42.42 AM.png (989×1 px, 171 KB)

Diff Detail

Repository
rP Phabricator
Branch
dd6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/drydock/storage/DrydockLease.php:350XHP16TODO Comment
Advicesrc/applications/drydock/view/DrydockLogListView.php:43XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8099
Build 9227: [Placeholder Plan] Wait for 30 Seconds
Build 9226: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Move Drydock logs to PHIDs and increased structure.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2015, 5:35 PM
This revision was automatically updated to reflect the committed changes.