Page MenuHomePhabricator
Differential D14190

Add a --target flag to `arc unit` for uploading results
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 2:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 1, 3:15 AM
Unknown Object (File)
Sun, Mar 31, 5:21 AM
Unknown Object (File)
Sun, Mar 24, 10:51 PM
Unknown Object (File)
Sun, Mar 24, 10:50 PM
Unknown Object (File)
Sun, Mar 24, 9:56 PM
Unknown Object (File)
Sun, Mar 24, 9:38 PM
Unknown Object (File)
Sun, Mar 24, 8:25 PM
Unknown Object (File)
Fri, Mar 22, 1:55 PM
View All Files
Subscribers
hach-que
Tokens
"Mountain of Wealth" token, awarded by avivey.

Details

Reviewers
chad
Maniphest Tasks
T5821: Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster
Commits
rARCd3abb6557252: Add a --target flag to `arc unit` for uploading results
Summary

Ref T5821. Basic idea here is that Harbormaster can run arc unit --everything --target ... to get a build target updated.

Test Plan

Ran arc unit --target ..., saw web UI update with test results.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34280.Sep 29 2015, 2:32 PM
epriestley retitled this revision from to Add a --target flag to `arc unit` for uploading results.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5821: Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster.
epriestley mentioned this in D11690: Allow unit test results to be outputted as JSON in realtime.Sep 29 2015, 2:33 PM
chad accepted this revision.Sep 29 2015, 4:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2015, 4:22 PM
Closed by commit rARCd3abb6557252: Add a --target flag to `arc unit` for uploading results (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 4:51 PM
This revision was automatically updated to reflect the committed changes.
avivey awarded a token.Sep 29 2015, 6:30 PM
hach-que added a subscriber: hach-que.Sep 30 2015, 12:18 PM
hach-que added inline comments.
src/workflow/ArcanistUnitWorkflow.php
427

What are the policies on this call? Can anyone attach unit test results to any Harbormaster build target?

epriestley mentioned this in T5821: Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster.Oct 1 2015, 3:25 PM

Revision Contents
Changeset List

Diff 34284

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistUnitWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility