Page MenuHomePhabricator
Differential D14167

Provide a stable URI for getting raw paste content
ClosedPublic
Actions

Authored by epriestley on Sep 25 2015, 5:18 PM.
Tags
None
Referenced Files
F14064522: D14167.diff
Mon, Nov 18, 11:50 PM
F14048726: D14167.id.diff
Thu, Nov 14, 9:25 AM
F14031131: D14167.id34224.diff
Sat, Nov 9, 9:23 AM
F14015108: D14167.diff
Sun, Nov 3, 1:44 PM
F14012496: D14167.id.diff
Fri, Nov 1, 1:37 PM
F14012495: D14167.id34232.diff
Fri, Nov 1, 1:37 PM
F14012313: D14167.diff
Fri, Nov 1, 10:46 AM
F14005235: D14167.id34232.diff
Sun, Oct 27, 9:39 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9312: URL Param to pass to Paste to download paste instead of viewing it
Commits
Restricted Diffusion Commit
rPb7ca5a2d2981: Provide a stable URI for getting raw paste content
Summary

Fixes T9312. This is a bit fluff, but does simplify the view controller slightly and seems reasonable/useful in general.

Test Plan

Clicked "View Raw File" on a paste, got redirected to the raw file via a stable URI.

Diff Detail

Repository
rP Phabricator
Branch
praw
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8058
Build 9150: [Placeholder Plan] Wait for 30 Seconds
Build 9149: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34224.Sep 25 2015, 5:18 PM
epriestley retitled this revision from to Provide a stable URI for getting raw paste content.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9312: URL Param to pass to Paste to download paste instead of viewing it.
chad accepted this revision.Sep 25 2015, 5:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:44 PM
Closed by commit rPb7ca5a2d2981: Provide a stable URI for getting raw paste content (authored by epriestley, committed by epriestley). · Explain WhySep 25 2015, 5:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
paste/
application/
1 line
controller/
39 lines
20 lines

Diff 34224

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/paste/application/PhabricatorPasteApplication.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteRawController.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...
Phabricator · Built by Phacility