Page MenuHomePhabricator
Differential D14158

Show recent active leases on Drydock resource detail
ClosedPublic
Actions

Authored by epriestley on Sep 24 2015, 8:51 PM.
Tags
None
Referenced Files
F14844458: D14158.diff
Sun, Feb 2, 3:58 PM
Unknown Object (File)
Fri, Jan 31, 5:42 AM
Unknown Object (File)
Fri, Jan 24, 9:06 AM
Unknown Object (File)
Fri, Jan 24, 9:06 AM
Unknown Object (File)
Fri, Jan 24, 9:06 AM
Unknown Object (File)
Fri, Jan 24, 9:06 AM
Unknown Object (File)
Fri, Jan 24, 2:48 AM
Unknown Object (File)
Fri, Jan 24, 1:06 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rP64ed97103993: Show recent active leases on Drydock resource detail
Summary

Ref T9252. This is the same as D14157, just for Resources and their leases.

Test Plan

Viewed a resource, saw only active leases, clicked "View All Leases", queried, clicked around, used crumbs.

Diff Detail

Repository
rP Phabricator
Branch
drydock13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8048
Build 9128: [Placeholder Plan] Wait for 30 Seconds
Build 9127: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34208.Sep 24 2015, 8:51 PM
epriestley updated this revision to Diff 34211.
epriestley retitled this revision from to Show recent active leases on Drydock resource detail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9252: Unprototype Drydock (v1).
  • Use setIconFont() directly.
epriestley mentioned this in D13686: [drydock/core] Only show active resources and leases in controllers.Sep 24 2015, 8:54 PM
chad accepted this revision.Sep 24 2015, 9:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2015, 9:49 PM
Closed by commit rP64ed97103993: Show recent active leases on Drydock resource detail (authored by epriestley, committed by epriestley). · Explain WhySep 24 2015, 10:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34211

View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseController.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseListController.php

Loading...
View Options

src/applications/drydock/controller/DrydockResourceController.php

Loading...
View Options

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...
View Options

src/applications/drydock/query/DrydockLeaseSearchEngine.php

Loading...
Phabricator · Built by Phacility