Differential D14149

Soften checks on a very old Maniphest transactionmigration
ClosedPublic
Actions

Authored by epriestley on Sep 24 2015, 1:43 AM.

Details

Reviewers

chad

Maniphest Tasks

T9464: /bin/storage upgrade fails while applying a patch.

Commits

Restricted Diffusion Commit
rP99e447244752: Soften checks on a very old Maniphest transactionmigration

Summary

Ref T9464. If an ancient transaction doesn't have array values for whatever reason, we fail here.

Instead, just recover as gracefully as we can. We may get the transaction "wrong" in some sense, but this only impacts what is rendered in the transaction log.

Test Plan

This is nearly a year old and there's no real way to test it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34189.Sep 24 2015, 1:43 AM

epriestley retitled this revision from to Soften checks on a very old Maniphest transactionmigration.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9464: /bin/storage upgrade fails while applying a patch..

spodermancoffee

This revision is now accepted and ready to land.Sep 24 2015, 1:44 AM

Closed by commit rP99e447244752: Soften checks on a very old Maniphest transactionmigration (authored by epriestley, committed by epriestley). · Explain WhySep 24 2015, 2:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20141222.maniphestprojtxn.php

52 lines

Diff 34190

View Options

resources/sql/autopatches/20141222.maniphestprojtxn.php

Soften checks on a very old Maniphest transactionmigrationClosedPublicActions