Page MenuHomePhabricator
Differential D14112

Fix an issue with "arc nrabch"
ClosedPublic
Actions

Authored by epriestley on Sep 15 2015, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 4:40 PM
Unknown Object (File)
Mon, Apr 29, 4:40 PM
Unknown Object (File)
Mon, Apr 29, 4:40 PM
Unknown Object (File)
Mon, Apr 29, 3:52 PM
Unknown Object (File)
Sat, Apr 27, 10:24 PM
Unknown Object (File)
Thu, Apr 25, 4:35 PM
Unknown Object (File)
Wed, Apr 24, 11:48 PM
Unknown Object (File)
Wed, Apr 24, 4:52 AM
View All Files
Subscribers
None

Details

Reviewers
BYK
chad
Commits
rARCb37b2c30345e: (stable) Promote 2015 Week 38
rARC083127c4cc5a: Fix an issue with "arc nrabch"
Summary

Fixes a minor issue from D14034. PHP doesn't like clone null;, and if you type a nonsense command like arc nbrhch (as I frequently do) we try to clone null here.

Instead, just return null; if no workflow matches. Clone otherwise.

Test Plan
  • Ran arc nbrhcanc
  • Ran arc branch

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34103.Sep 15 2015, 4:45 PM
epriestley retitled this revision from to Fix an issue with "arc nrabch".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, BYK.
chad accepted this revision.Sep 15 2015, 4:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 15 2015, 4:47 PM
Closed by commit rARC083127c4cc5a: Fix an issue with "arc nrabch" (authored by epriestley, committed by epriestley). · Explain WhySep 15 2015, 6:14 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9426: Can no longer run aliased commands.Sep 16 2015, 12:09 AM

Revision Contents
Changeset List

PathSize
src/
configuration/
8 lines

Diff 34106

View Options

src/configuration/ArcanistConfiguration.php

Loading...
Phabricator · Built by Phacility