Page MenuHomePhabricator
Differential D14106

More linter's short description
ClosedPublic
Actions

Authored by avivey on Sep 14 2015, 6:48 PM.
Tags
None
Referenced Files
F14095824: D14106.diff
Mon, Nov 25, 11:54 PM
Unknown Object (File)
Fri, Nov 22, 9:13 AM
Unknown Object (File)
Fri, Nov 22, 1:20 AM
Unknown Object (File)
Fri, Nov 22, 1:20 AM
Unknown Object (File)
Fri, Nov 22, 1:19 AM
Unknown Object (File)
Wed, Nov 20, 9:29 PM
Unknown Object (File)
Mon, Nov 18, 1:48 AM
Unknown Object (File)
Sun, Nov 17, 6:00 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9353: make arc linters one-line output more informative
Commits
rARC501007f0122e: More linter's short description
Summary

Closes T9353. I think this makes all descriptions at least basically informative.

Test Plan

arc linters - I can now understand what each one is about.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7976
Build 8981: [Placeholder Plan] Wait for 30 Seconds
Build 8980: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 34091.Sep 14 2015, 6:48 PM
avivey retitled this revision from to More linter's short description.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
avivey added a task: T9353: make arc linters one-line output more informative.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 14 2015, 6:48 PM
Herald added a subscriber: Korvin. · View Herald Transcript
avivey added inline comments.Sep 14 2015, 6:49 PM
src/lint/linter/ArcanistLesscLinter.php
27

They don't have https, at least not right now.

avivey edited the test plan for this revision. (Show Details)Sep 14 2015, 6:51 PM
avivey edited edge metadata.
epriestley accepted this revision.Sep 14 2015, 6:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 14 2015, 6:51 PM
Closed by commit rARC501007f0122e: More linter's short description (authored by avivey, committed by avivey). · Explain WhySep 14 2015, 6:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
4 lines
2 lines

Diff 34091

View Options

src/lint/linter/ArcanistLesscLinter.php

Loading...
View Options

src/lint/linter/ArcanistPEP8Linter.php

Loading...
Phabricator · Built by Phacility