Remove dot/Graphviz Remarkup rule
ClosedPublic
Actions

Authored by epriestley on Sep 13 2015, 7:22 PM.

Details

Reviewers

chad

Maniphest Tasks

T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`

Commits

Restricted Diffusion Commit
rPc02f750267f8: Remove dot/Graphviz Remarkup rule

Summary

Ref T9408. This rule is unsafe in principle, and a practical vulnerability has been found by a security researcher.

Test Plan

grep

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34082.Sep 13 2015, 7:22 PM

epriestley retitled this revision from to Remove dot/Graphviz Remarkup rule.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`.

chad accepted this revision.Sep 13 2015, 7:22 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 13 2015, 7:22 PM

Closed by commit rPc02f750267f8: Remove dot/Graphviz Remarkup rule (authored by epriestley, committed by epriestley). · Explain WhySep 13 2015, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

infrastructure/

markup/

interpreter/

PhabricatorRemarkupGraphvizBlockInterpreter.php

Diff 34084

View Options

src/__phutil_library_map__.php