Differential D14016

Rename "Edit Column" to "Column Details"
ClosedPublic
Actions

Authored by epriestley on Aug 31 2015, 2:17 PM.

Details

Reviewers

chad

Maniphest Tasks

T9089: Clicking "Edit column" should provide user feedback

Commits

Restricted Diffusion Commit
rPe67c438943f2: Rename "Edit Column" to "Column Details"

Summary

Ref T9089. This link leads to a detail page, not an edit page, and is always visible by users with permission to see the column.

Test Plan

Clicked "Column Details" with and without edit permission.

Diff Detail

Repository

rP Phabricator

Branch

wperm2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7857
Build 8745: [Placeholder Plan] Wait for 30 Seconds
Build 8744: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33892.Aug 31 2015, 2:17 PM

epriestley retitled this revision from to Rename "Edit Column" to "Column Details".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9089: Clicking "Edit column" should provide user feedback.

chad accepted this revision.Aug 31 2015, 2:19 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2015, 2:19 PM

Closed by commit rPe67c438943f2: Rename "Edit Column" to "Column Details" (authored by epriestley, committed by epriestley). · Explain WhyAug 31 2015, 5:17 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9089: Clicking "Edit column" should provide user feedback.Dec 8 2015, 11:12 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

10 lines

PhabricatorProjectColumnDetailController.php

12 lines

Diff 33892

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php