Page MenuHomePhabricator

Fix Ponder Answer email reply handler
ClosedPublic

Authored by chad on Aug 21 2015, 4:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:28 PM
Unknown Object (File)
Wed, Nov 20, 2:14 PM
Unknown Object (File)
Wed, Nov 20, 11:38 AM
Unknown Object (File)
Wed, Nov 20, 11:38 AM
Unknown Object (File)
Wed, Nov 20, 11:38 AM
Unknown Object (File)
Sun, Nov 17, 12:49 PM
Unknown Object (File)
Sat, Nov 9, 9:58 AM
Unknown Object (File)
Sat, Nov 9, 9:58 AM
Subscribers

Details

Summary

Should fix all email reply issues, but no solid means of testing at home (how do you local reply test?)

Test Plan

Check for answer mail in /mail/ and see proper headers. Make sure question mail works too.

Diff Detail

Repository
rP Phabricator
Branch
ponder-mail
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7711
Build 8457: [Placeholder Plan] Wait for 30 Seconds
Build 8456: arc lint + arc unit

Event Timeline

chad retitled this revision from to Fix Ponder Answer email reply handler.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

The easiest way to test inbound mail is generally:

$ nano body.txt # Write the body of your mail
$ ./bin/mail receive-test --as epriestley --to D123 < body.txt

Since A123 isn't actually an object monogram (I think?), I'm not sure if A123 will work, though. If it doesn't, the answer PHID might.

I think the reason these Editors share some of the templating code is to try to get questions and answers to thread together. At least in Mail.app, they aren't always threading together even now, and this change will probably make them thread together less often in more clients. But maybe that's fine.

This revision is now accepted and ready to land.Aug 21 2015, 10:55 AM
chad edited edge metadata.
  • use correct monogram
This revision was automatically updated to reflect the committed changes.