Page MenuHomePhabricator
Differential D13898

Allow PhutilClassMapQuery to load implementors of an interface
ClosedPublic
Actions

Authored by epriestley on Aug 14 2015, 12:58 PM.
Tags
None
Referenced Files
F13996434: D13898.diff
Wed, Oct 23, 9:07 PM
F13966632: D13898.id33550.diff
Wed, Oct 16, 8:48 AM
F13965519: D13898.id.diff
Wed, Oct 16, 2:34 AM
Unknown Object (File)
Oct 3 2024, 10:22 AM
Unknown Object (File)
Sep 21 2024, 7:05 AM
Unknown Object (File)
Sep 5 2024, 3:42 PM
Unknown Object (File)
Sep 5 2024, 3:42 PM
Unknown Object (File)
Sep 5 2024, 3:42 PM
View All Files
Subscribers
None

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T9179: flag queries cause exceptions
Commits
rPHUe509fc30ae78: Allow PhutilClassMapQuery to load implementors of an interface
Summary

Fixes T9179. The old way worked for interfaces, but the new way didn't; it should.

Test Plan

No more fatal on /flag/.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33549.Aug 14 2015, 12:58 PM
epriestley retitled this revision from to Allow PhutilClassMapQuery to load implementors of an interface.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
epriestley added a task: T9179: flag queries cause exceptions.
joshuaspence accepted this revision.Aug 14 2015, 1:02 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2015, 1:02 PM
Closed by commit rPHUe509fc30ae78: Allow PhutilClassMapQuery to load implementors of an interface (authored by epriestley, committed by epriestley). · Explain WhyAug 14 2015, 1:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
symbols/
9 lines

Diff 33550

View Options

src/symbols/PhutilClassMapQuery.php

Loading...
Phabricator · Built by Phacility