Paths

Table of Contentst

Differential D13880

Add some missing translation strings
ClosedPublic
Actions

Authored by joshuaspence on Aug 13 2015, 4:59 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP7938d9a52960: Add some missing translation strings

Summary

Self explanatory.

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33516.Aug 13 2015, 4:59 AM

joshuaspence retitled this revision from to Add some missing translation strings.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 13 2015, 4:59 AM

Herald added a subscriber: Korvin. · View Herald Transcript

I think elsewhere we've removed the number in the translated version. For example, instead of:

epriestley edited dependencies, added 2: a, b; removed 3: c, d, e.

...just:

epriestley edited dependencies, added: a, b; removed: c, d, e.

e.g., see the similar strings on lines 611-612. You'll need to %4$s, etc., to skip parameters.

This revision is now accepted and ready to land.Aug 13 2015, 1:57 PM

Remove numbers

Closed by commit rP7938d9a52960: Add some missing translation strings (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 13 2015, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

8 lines

Diff 33529

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Add some missing translation stringsClosedPublicActions