Differential D13871

Add a linter rule for inline HTML
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 2:31 PM.

Tags

None

Referenced Files

	F14095310: D13871.diff
	Mon, Nov 25, 8:30 PM

	F14091991: D13871.diff
	Mon, Nov 25, 3:30 AM

	Unknown Object (File)
	Fri, Nov 22, 11:31 AM

	Unknown Object (File)
	Mon, Nov 11, 5:58 AM

	Unknown Object (File)
	Sat, Nov 9, 7:44 AM

	Unknown Object (File)
	Thu, Nov 7, 3:52 AM

	Unknown Object (File)
	Wed, Nov 6, 6:22 PM

	Unknown Object (File)
	Mon, Nov 4, 2:51 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

Restricted Maniphest Task
T7409: Implement PHPCS lints

Commits

rARC2e76e2965cbe: Add a linter rule for inline HTML

Summary

Ref T7409. Based on InlineHTMLSniff.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7597
Build 8234: [Placeholder Plan] Wait for 30 Seconds
Build 8233: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	173,694 ms	ArcanistXHPASTLinterTestCase::Unknown Unit Message ("")
	231 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	1,768 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	203 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	660 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 47 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33498.Aug 11 2015, 2:31 PM

joshuaspence retitled this revision from to Add a linter rule for inline HTML.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 2:31 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 11 2015, 2:47 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2015, 2:47 PM

• smij added a reviewer: • smij.Aug 11 2015, 8:34 PM

• smij removed a reviewer: • smij.Aug 11 2015, 8:37 PM

• smij added a task: Restricted Maniphest Task.

Closed by commit rARC2e76e2965cbe: Add a linter rule for inline HTML (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 13 2015, 9:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

-

-

lint/

linter/

ArcanistInlineHTMLXHPASTLinterRule.php

31 lines

100%

Loading...

__tests__/

xhpast/

inline-html.lint-test

4 lines

-

-

Diff 33498

src/__phutil_library_map__.php

Loading...

src/lint/linter/ArcanistInlineHTMLXHPASTLinterRule.php

Loading...

src/lint/linter/tests/xhpast/inline-html.lint-test

Loading...