Page MenuHomePhabricator

Link to Harbormaster build targets from the Daemon worker page
ClosedPublic

Authored by epriestley on Aug 10 2015, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:59 PM
Unknown Object (File)
Wed, Apr 17, 2:31 PM
Unknown Object (File)
Tue, Apr 16, 4:11 PM
Unknown Object (File)
Fri, Apr 5, 1:42 AM
Unknown Object (File)
Wed, Apr 3, 2:38 PM
Unknown Object (File)
Mon, Apr 1, 3:44 AM
Unknown Object (File)
Mar 19 2024, 8:47 AM
Unknown Object (File)
Feb 7 2024, 8:52 PM
Subscribers
None

Details

Summary

Fixes T7370. Two changes:

  • Make the default to show nothing, instead of showing all the data. This is a better default because the data is sometimes sensitive. Workers should have to opt in to revealing it.
  • For TargetWorkers, link to the target (technically the build, for now, since there's no dedicated target detail page).
Test Plan

Screen Shot 2015-08-10 at 11.47.16 AM.png (1×2 px, 376 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Link to Harbormaster build targets from the Daemon worker page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Do the same thing for BuildWorkers.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 7:25 PM
This revision was automatically updated to reflect the committed changes.