Page MenuHomePhabricator
Differential D13841

Improve PHP compatibility linter
ClosedPublic
Actions

Authored by joshuaspence on Aug 10 2015, 10:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 1:10 PM
Unknown Object (File)
Mon, Feb 10, 1:33 PM
Unknown Object (File)
Sat, Feb 8, 9:53 PM
Unknown Object (File)
Sat, Feb 8, 9:53 PM
Unknown Object (File)
Sat, Feb 8, 9:53 PM
Unknown Object (File)
Sat, Feb 8, 9:53 PM
Unknown Object (File)
Mon, Feb 3, 3:25 AM
Unknown Object (File)
Mon, Feb 3, 12:21 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results
Commits
rARCf43b74c6052f: Improve PHP compatibility linter
Summary

Ref T8674. Adds to ArcanistPHPCompatibilityXHPASTLinterRule such that an error is raised whenever self or $this is used in an anonymous closure prior to PHP 5.4.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33422.Aug 10 2015, 10:06 AM
joshuaspence retitled this revision from to Improve PHP compatibility linter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 10 2015, 10:06 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 10 2015, 1:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 1:29 PM
Closed by commit rARCf43b74c6052f: Improve PHP compatibility linter (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 10 2015, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
xhpast/
17 lines
xhpast/
rules/
46 lines

Diff 33440

View Options

src/lint/linter/__tests__/xhpast/php54-features.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility