Page MenuHomePhabricator

Improve PHP compatibility linter
ClosedPublic

Authored by joshuaspence on Aug 10 2015, 10:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 7:33 PM
Unknown Object (File)
Thu, Jan 30, 2:32 AM
Unknown Object (File)
Wed, Jan 29, 7:37 PM
Unknown Object (File)
Wed, Jan 29, 7:35 PM
Unknown Object (File)
Sun, Jan 26, 2:30 PM
Unknown Object (File)
Sun, Jan 26, 2:30 PM
Unknown Object (File)
Fri, Jan 24, 7:58 AM
Unknown Object (File)
Fri, Jan 24, 7:58 AM
Subscribers

Details

Summary

Ref T8674. Adds to ArcanistPHPCompatibilityXHPASTLinterRule such that an error is raised whenever self or $this is used in an anonymous closure prior to PHP 5.4.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improve PHP compatibility linter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 1:29 PM
This revision was automatically updated to reflect the committed changes.