Page MenuHomePhabricator
Differential D13804

Improve declaration formatting linter rule for anonymous functions
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2015, 10:28 PM.
Tags
None
Referenced Files
F14406674: D13804.diff
Mon, Dec 23, 7:03 PM
Unknown Object (File)
Wed, Dec 11, 4:15 PM
Unknown Object (File)
Wed, Dec 11, 11:04 AM
Unknown Object (File)
Tue, Dec 10, 8:31 PM
Unknown Object (File)
Sat, Dec 7, 2:13 AM
Unknown Object (File)
Sat, Dec 7, 1:21 AM
Unknown Object (File)
Tue, Dec 3, 1:07 PM
Unknown Object (File)
Thu, Nov 28, 4:28 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8742: Write a bunch of PSR-2 lint rules
Commits
rARC9e65fc65164a: Improve declaration formatting linter rule for anonymous functions
Summary

Ref T8742. Anonymous functions should have a space after the function keyword. Additionally, ensure that there is a space before and after the use token.

Test Plan

Modified existing test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7503
Build 8046: [Placeholder Plan] Wait for 30 Seconds
Build 8045: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33342.Aug 5 2015, 10:28 PM
joshuaspence retitled this revision from to Improve declaration formatting linter rule for anonymous functions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T8742: Write a bunch of PSR-2 lint rules.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2015, 10:28 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 8 2015, 4:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 8 2015, 4:36 PM
Closed by commit rARC9e65fc65164a: Improve declaration formatting linter rule for anonymous functions (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 8 2015, 11:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33342

View Options

src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/inner-function.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php53-features.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/reused-iterator-reference.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/switches.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistDeclarationParenthesesXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility