Page MenuHomePhabricator

Lump Harbormaster build steps into groups
ClosedPublic

Authored by epriestley on Aug 5 2015, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 6:04 PM
Unknown Object (File)
Tue, Dec 3, 5:33 PM
Unknown Object (File)
Tue, Dec 3, 5:33 PM
Unknown Object (File)
Tue, Dec 3, 5:27 PM
Unknown Object (File)
Tue, Dec 3, 5:06 PM
Unknown Object (File)
Mon, Dec 2, 5:32 PM
Unknown Object (File)
Wed, Nov 27, 9:37 PM
Unknown Object (File)
Tue, Nov 26, 8:57 PM
Subscribers
None

Details

Summary

Ref T8089. We have a lot of broken/confusing/prototype build steps that I want to hide from users when we unprototype Harbormaster.

The dialog is also just kind of unwieldy.

Organize this UI a little better and put all the sketchy junk in a "prototypes" group that you can't see unless prototypes are enabled.

This doesn't break anything (the old steps will still work fine), but should reduce user confusion.

Test Plan

Old UI:

Screen Shot 2015-08-05 at 2.41.14 PM.png (603×547 px, 60 KB)

New UI (prototypes off):

Screen Shot 2015-08-05 at 2.42.04 PM.png (1×1 px, 145 KB)

New UI (prototypes on):

Screen Shot 2015-08-05 at 2.42.08 PM.png (1×1 px, 183 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Lump Harbormaster build steps into groups.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Aug 5 2015, 10:11 PM
This revision was automatically updated to reflect the committed changes.