Page MenuHomePhabricator
Differential D13796

Add a linter rule for spacing before opening parenthesis in function calls
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2015, 10:22 AM.
Tags
None
Referenced Files
F14094900: D13796.diff
Mon, Nov 25, 6:13 PM
Unknown Object (File)
Sun, Nov 24, 11:43 AM
Unknown Object (File)
Sun, Nov 24, 4:47 AM
Unknown Object (File)
Thu, Nov 21, 8:19 AM
Unknown Object (File)
Wed, Nov 20, 4:52 AM
Unknown Object (File)
Wed, Nov 20, 4:25 AM
Unknown Object (File)
Wed, Nov 20, 2:38 AM
Unknown Object (File)
Wed, Nov 20, 2:18 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC1e75302e7703: Add a linter rule for spacing before opening parenthesis in function calls
Summary

Repurpose ArcanistClosingCallParenthesesXHPASTLinterRule (and rename it to ArcanistCallParenthesesXHPASTLinterRule) to ensure that there is no spacing before opening parenthesis in function calls.

Test Plan

Added test case.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7500
Build 8040: [Placeholder Plan] Wait for 30 Seconds
Build 8039: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33318.Aug 5 2015, 10:22 AM
joshuaspence retitled this revision from to Add a linter rule for spacing before opening parenthesis in function calls.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2015, 10:22 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 5 2015, 3:57 PM
epriestley edited edge metadata.

One inline thing I think?

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php
32

I think this string is wrong, and actually testing for space before the opening parenthesis?

This revision is now accepted and ready to land.Aug 5 2015, 3:57 PM
joshuaspence updated this revision to Diff 33336.Aug 5 2015, 8:58 PM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Fix lint message

Closed by commit rARC1e75302e7703: Add a linter rule for spacing before opening parenthesis in function calls (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 5 2015, 9:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
__tests__/
xhpast/
3 lines
xhpast/
rules/
ArcanistCallParenthesesXHPASTLinterRule.php
ArcanistClosingCallParenthesesXHPASTLinterRule.php
18 lines

Diff 33336

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/call-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClosingCallParenthesesXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility