Paths

Table of Contentst

Differential D13794

Allow closing tags in files containing HTML
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2015, 4:29 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8742: Write a bunch of PSR-2 lint rules

Commits

rARC402899a9c32d: Allow closing tags in files containing HTML

Summary

Ref T8742. PHP files which contain inline HTML should be allowed to use PHP closing tags (?>). This is in accordance with PSR-2 guidelines.

Test Plan

Updated unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7489
Build 8018: [Placeholder Plan] Wait for 30 Seconds
Build 8017: arc lint + arc unit

Unit TestsFailed
View All

Excuse: Unrelated

	Time	Test
	1,994 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	1,005 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	138 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	183 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	36 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 50 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33314.Aug 5 2015, 4:29 AM

joshuaspence retitled this revision from to Allow closing tags in files containing HTML.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8742: Write a bunch of PSR-2 lint rules.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2015, 4:29 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 5 2015, 3:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 5 2015, 3:58 PM

Closed by commit rARC402899a9c32d: Allow closing tags in files containing HTML (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 5 2015, 8:56 PM

This revision was automatically updated to reflect the committed changes.

asherkin mentioned this in D18271: Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out.Jul 24 2017, 1:52 PM

asherkin mentioned this in rARC836768bdccd4: Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out.Jul 24 2017, 1:56 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

__tests__/

xhpast/

embedded-tags.lint-test

1 line

-

-

php-tags-bad.lint-test

1 line

-

-

xhpast/

rules/

ArcanistPHPCloseTagXHPASTLinterRule.php

6 lines

40%

Loading...

Diff 33314

src/lint/linter/tests/xhpast/embedded-tags.lint-test

Loading...

src/lint/linter/tests/xhpast/php-tags-bad.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistPHPCloseTagXHPASTLinterRule.php

Loading...