Put spaces back in condition rendering
ClosedPublic
Actions

Authored by epriestley on Aug 3 2015, 10:36 PM.

Tags

None

Referenced Files

	F18107410: D13780.diff
	Mon, Aug 11, 12:40 AM

	F18087173: D13780.id33286.diff
	Wed, Aug 6, 2:41 AM

	F18084994: D13780.id.diff
	Tue, Aug 5, 6:55 PM

	F17852694: D13780.id.diff
	Jul 27 2025, 12:58 PM

	F17836715: D13780.diff
	Jul 26 2025, 4:27 PM

	F17715829: D13780.id33284.diff
	Jul 17 2025, 3:25 PM

	Unknown Object (File)
	Jun 6 2025, 2:24 AM

	Unknown Object (File)
	Jun 5 2025, 2:09 PM

View All Files

Subscribers

None

Details

Reviewers

joshuaspence
chad

Maniphest Tasks

T9055: Weird Herald spacing

Commits

Restricted Diffusion Commit
rP05c571794b5d: Put spaces back in condition rendering

Summary

Fixes T9055. I mostly tested with "Always" rules so I missed this.

Test Plan

Screen Shot 2015-08-03 at 3.35.41 PM.png (233×365 px, 21 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33284.Aug 3 2015, 10:36 PM

epriestley retitled this revision from to Put spaces back in condition rendering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, chad.

epriestley added a task: T9055: Weird Herald spacing.

Feels a bit icky, but sure.

This revision is now accepted and ready to land.Aug 3 2015, 10:38 PM

Closed by commit rP05c571794b5d: Put spaces back in condition rendering (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 10:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

2 lines

Diff 33286

View Options

src/applications/herald/adapter/HeraldAdapter.php

Put spaces back in condition renderingClosedPublicActions