Differential D13750

Add Priority to Maniphest Hovercard
ClosedPublic
Actions

Authored by chad on Jul 28 2015, 10:12 PM.

Tags

None

Referenced Files

	F14002779: D13750.id33211.diff
	Fri, Oct 25, 10:23 PM

	F13989682: D13750.diff
	Mon, Oct 21, 10:19 PM

	F13962758: D13750.id.diff
	Oct 15 2024, 12:07 PM

	Unknown Object (File)
	Sep 30 2024, 5:42 PM

	Unknown Object (File)
	Sep 26 2024, 11:12 AM

	Unknown Object (File)
	Sep 14 2024, 1:36 AM

	Unknown Object (File)
	Sep 4 2024, 3:13 AM

	Unknown Object (File)
	Sep 1 2024, 11:27 PM

Subscribers

Details

Reviewers

epriestley
lpriestley

Maniphest Tasks

T5524: Show task priority in task hovercards in remarkup

Commits

Restricted Diffusion Commit
rPfb13692bd3e5: Add Priority to Maniphest Hovercard

Summary

Fixes T5524, adds priority to Maniphest's hovercard. Also fixes Blocking language.

Test Plan

Hover over a task, see new stuff.

Diff Detail

Repository

Branch

hovercard-priority

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7435
Build 7910: [Placeholder Plan] Wait for 30 Seconds
Build 7909: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	58 ms	ManiphestTaskTestCase::Unknown Unit Message ("")
	9 ms	ManiphestTaskTestCase::Unknown Unit Message ("")
	1,610 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("")
	9 ms	PhabricatorConduitTestCase::Unknown Unit Message ("")
	0 ms	PhabricatorInfrastructureTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 7 Passed)

Event Timeline

chad updated this revision to Diff 33211.Jul 28 2015, 10:12 PM

chad retitled this revision from to Add Priority to Maniphest Hovercard.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, lpriestley.

chad added a task: T5524: Show task priority in task hovercards in remarkup.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 28 2015, 10:12 PM

The unit test fail is that I have custom fields that are required.

thumbsup

epriestley accepted this revision.Jul 29 2015, 12:18 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 29 2015, 12:18 AM

Closed by commit rPfb13692bd3e5: Add Priority to Maniphest Hovercard (authored by chad, committed by chad). · Explain WhyJul 29 2015, 2:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

event/

ManiphestHovercardEventListener.php

7 lines

Diff 33211

src/applications/maniphest/event/ManiphestHovercardEventListener.php

Loading...