Page MenuHomePhabricator
Differential D13708

Show badges on timelines
ClosedPublic
Actions

Authored by epriestley on Jul 24 2015, 11:01 PM.
Tags
None
Referenced Files
F15530285: D13708.id33128.diff
Wed, Apr 23, 3:21 AM
F15528854: D13708.id33128.diff
Tue, Apr 22, 2:28 PM
F15528023: D13708.diff
Tue, Apr 22, 8:24 AM
F15524623: D13708.id.diff
Mon, Apr 21, 9:21 AM
F15524563: D13708.id.diff
Mon, Apr 21, 8:53 AM
F15521017: D13708.diff
Sun, Apr 20, 10:26 AM
F15519535: D13708.id33128.diff
Sat, Apr 19, 11:36 PM
F15519534: D13708.id33127.diff
Sat, Apr 19, 11:36 PM
View All Files
Subscribers
epriestley
Tokens
"Pterodactyl" token, awarded by joshuaspence.

Details

Reviewers
chad
Maniphest Tasks
T8941: Badges don't show in certain Timeline conditions
Commits
Restricted Diffusion Commit
rP343801d44919: Show badges on timelines
Summary

Ref T8941.

Test Plan

Screen Shot 2015-07-24 at 4.00.02 PM.png (291×327 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Branch
badgeview
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/view/phui/PHUITimelineView.php:249XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7386
Build 7812: [Placeholder Plan] Wait for 30 Seconds
Build 7811: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33127.Jul 24 2015, 11:01 PM
epriestley retitled this revision from to Show badges on timelines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8941: Badges don't show in certain Timeline conditions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2015, 11:01 PM
chad accepted this revision.Jul 24 2015, 11:02 PM
chad edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Jul 24 2015, 11:02 PM
Closed by commit rP343801d44919: Show badges on timelines (authored by epriestley, committed by epriestley). · Explain WhyJul 24 2015, 11:04 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence awarded a token.Jul 25 2015, 1:20 AM
epriestley mentioned this in T8941: Badges don't show in certain Timeline conditions.Jan 2 2016, 12:26 AM

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
view/
13 lines
view/
phui/
16 lines
10 lines
78 lines

Diff 33127

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

src/view/phui/PHUIBadgeMiniView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
Phabricator · Built by Phacility