Page MenuHomePhabricator
Differential D13634

Implementing Spaces in Countdown
ClosedPublic
Actions

Authored by SalmonKiller on Jul 14 2015, 11:45 PM.
Tags
None
Referenced Files
F15460549: D13634.diff
Mon, Mar 31, 11:54 PM
F15445788: D13634.id.diff
Thu, Mar 27, 4:02 PM
F15424297: D13634.diff
Sat, Mar 22, 9:19 PM
F15420531: D13634.id32947.diff
Fri, Mar 21, 2:40 PM
F15417930: D13634.id32956.diff
Thu, Mar 20, 7:30 PM
F15415500: D13634.id.diff
Thu, Mar 20, 6:17 AM
F15405352: D13634.diff
Tue, Mar 18, 11:13 AM
F15395217: D13634.diff
Sun, Mar 16, 3:50 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
lpriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8895: Modernize Countdown
Commits
Restricted Diffusion Commit
rPae281301cac5: Implementing Spaces in Countdown
Summary

Implements T8734

Test Plan

Verify that countdowns can have spaces associated with them. Verify that non-default spaces are displayed in the header of the countdowns in the result of the query.

Diff Detail

Repository
rP Phabricator
Branch
spacesincountdown
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7275
Build 7589: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

SalmonKiller updated this revision to Diff 32947.Jul 14 2015, 11:45 PM
SalmonKiller retitled this revision from to Implementing Spaces in Countdown.
SalmonKiller updated this object.
SalmonKiller edited the test plan for this revision. (Show Details)
SalmonKiller added reviewers: epriestley, lpriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 14 2015, 11:45 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 15 2015, 5:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2015, 5:17 PM
epriestley awarded a token.Jul 15 2015, 5:17 PM
Closed by commit rPae281301cac5: Implementing Spaces in Countdown (authored by SalmonKiller, committed by epriestley). · Explain WhyJul 15 2015, 5:18 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T8895: Modernize Countdown.Jul 24 2015, 10:02 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
1 line
applications/
countdown/
controller/
4 lines
query/
2 lines
storage/
14 lines

Diff 32947

View Options

resources/sql/autopatches/20150714.spaces.countdown.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownEditController.php

Loading...
View Options

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

Loading...
View Options

src/applications/countdown/storage/PhabricatorCountdown.php

Loading...
Phabricator · Built by Phacility