Paths

Table of Contentst

Differential D13573

Use PhutilClassMapQuery instead of PhutilSymbolLoader
ClosedPublic
Actions

Authored by joshuaspence on Jul 7 2015, 10:08 AM.

Tags

None

Referenced Files

	F15533773: D13573.diff
	Wed, Apr 23, 9:58 PM

	F15484535: D13573.id33443.diff
	Wed, Apr 9, 6:50 PM

	F15453199: D13573.id33443.diff
	Mar 29 2025, 10:05 AM

	F15452398: D13573.id32799.diff
	Mar 29 2025, 4:29 AM

	F15447290: D13573.diff
	Mar 27 2025, 10:55 PM

	F15428578: D13573.id32799.diff
	Mar 23 2025, 9:14 PM

	F15414742: D13573.id32799.diff
	Mar 20 2025, 2:21 AM

	F15414019: D13573.id32799.diff
	Mar 19 2025, 10:33 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC0e0957872083: Use PhutilClassMapQuery instead of PhutilSymbolLoader

Summary

Use PhutilClassMapQuery instead of PhutilSymbolLoader, mainly for consistency. Depends on D13572.

Test Plan

Ran a bunch of arc commands.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7171
Build 7387: [Placeholder Plan] Wait for 30 Seconds
Build 7386: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	118 ms	PhpunitTestEngineTestCase::Unknown Unit Message ("")
	108 ms	ArcanistBritishTestCase::Unknown Unit Message ("")
	93 ms	ArcanistBritishTestCase::Unknown Unit Message ("")
	2,940 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
	107 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 10 Passed)

Event Timeline

joshuaspence updated this revision to Diff 32799.Jul 7 2015, 10:08 AM

joshuaspence retitled this revision from to Use PhutilClassMapQuery instead of PhutilSymbolLoader.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D13572: Allow PhutilClassMapQuery to filter null.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2015, 10:08 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 7 2015, 12:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 7 2015, 12:35 PM

joshuaspence edited the test plan for this revision. (Show Details)Aug 10 2015, 8:51 PM

joshuaspence edited edge metadata.

Closed by commit rARC0e0957872083: Use PhutilClassMapQuery instead of PhutilSymbolLoader (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 10 2015, 8:51 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D13864: Fix `arc unit --everything`.Aug 11 2015, 12:20 PM

joshuaspence mentioned this in rARC01c3f4120741: Fix `arc unit --everything`.Aug 11 2015, 12:37 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

configuration/

ArcanistConfiguration.php

24 lines

28%

Loading...

lint/

engine/

ArcanistConfigurationDrivenLintEngine.php

32 lines

0%

Loading...

unit/

engine/

PhutilUnitTestEngine.php

6 lines

22%

Loading...

workflow/

ArcanistLintersWorkflow.php

4 lines

0%

Loading...

Diff 32799

src/configuration/ArcanistConfiguration.php

Loading...

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php

Loading...

src/unit/engine/PhutilUnitTestEngine.php

Loading...

src/workflow/ArcanistLintersWorkflow.php

Loading...