Page MenuHomePhabricator
Differential D13573

Use PhutilClassMapQuery instead of PhutilSymbolLoader
ClosedPublic
Actions

Authored by joshuaspence on Jul 7 2015, 10:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 19 2024, 12:41 AM
Unknown Object (File)
Sep 21 2024, 11:08 PM
Unknown Object (File)
Sep 21 2024, 11:08 PM
Unknown Object (File)
Sep 21 2024, 11:08 PM
Unknown Object (File)
Sep 21 2024, 10:57 PM
Unknown Object (File)
Sep 12 2024, 7:49 AM
Unknown Object (File)
Sep 5 2024, 2:55 PM
Unknown Object (File)
Sep 1 2024, 12:01 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC0e0957872083: Use PhutilClassMapQuery instead of PhutilSymbolLoader
Summary

Use PhutilClassMapQuery instead of PhutilSymbolLoader, mainly for consistency. Depends on D13572.

Test Plan

Ran a bunch of arc commands.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 7171
Build 7387: [Placeholder Plan] Wait for 30 Seconds
Build 7386: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
118 msPhpunitTestEngineTestCase::Unknown Unit Message ("")
108 msArcanistBritishTestCase::Unknown Unit Message ("")
93 msArcanistBritishTestCase::Unknown Unit Message ("")
2,940 msArcanistLibraryTestCase::Unknown Unit Message ("")
107 msArcanistLibraryTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 10 Passed)

Event Timeline

joshuaspence updated this revision to Diff 32799.Jul 7 2015, 10:08 AM
joshuaspence retitled this revision from to Use PhutilClassMapQuery instead of PhutilSymbolLoader.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D13572: Allow PhutilClassMapQuery to filter null.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2015, 10:08 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 7 2015, 12:35 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 7 2015, 12:35 PM
joshuaspence edited the test plan for this revision. (Show Details)Aug 10 2015, 8:51 PM
joshuaspence edited edge metadata.
Closed by commit rARC0e0957872083: Use PhutilClassMapQuery instead of PhutilSymbolLoader (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 10 2015, 8:51 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D13864: Fix `arc unit --everything`.Aug 11 2015, 12:20 PM
joshuaspence mentioned this in rARC01c3f4120741: Fix `arc unit --everything`.Aug 11 2015, 12:37 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
configuration/
24 lines28%
Loading...
lint/
engine/
32 lines0%
Loading...
unit/
engine/
6 lines22%
Loading...
workflow/
4 lines0%
Loading...

Diff 32799

View Options

src/configuration/ArcanistConfiguration.php

Loading...
View Options

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php

Loading...
View Options

src/unit/engine/PhutilUnitTestEngine.php

Loading...
View Options

src/workflow/ArcanistLintersWorkflow.php

Loading...
Phabricator · Built by Phacility