Page MenuHomePhabricator
Differential D13555

Add hidpi media query for mozilla browsers
ClosedPublic
Actions

Authored by chad on Jul 5 2015, 6:29 PM.
Tags
None
Referenced Files
F14475941: D13555.id32752.diff
Fri, Dec 27, 9:55 PM
F14475939: D13555.id.diff
Fri, Dec 27, 9:55 PM
Unknown Object (File)
Thu, Dec 12, 7:13 AM
Unknown Object (File)
Thu, Dec 12, 5:14 AM
Unknown Object (File)
Sat, Dec 7, 11:57 AM
Unknown Object (File)
Fri, Dec 6, 5:25 PM
Unknown Object (File)
Fri, Dec 6, 5:29 AM
Unknown Object (File)
Wed, Dec 4, 8:41 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP0cd5031ada4e: Add hidpi media query for mozilla browsers
Summary

Modern mozilla browsers use min-resolution.

Test Plan

Regernate sprites, use site in Firefox, see correct header image.

Diff Detail

Repository
rP Phabricator
Branch
moz-retina
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7147
Build 7342: [Placeholder Plan] Wait for 30 Seconds
Build 7341: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32749.Jul 5 2015, 6:29 PM
chad retitled this revision from to Add hidpi media query for mozilla browsers.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 5 2015, 6:29 PM
chad added a comment.Jul 5 2015, 6:29 PM

heh, guess my local macbook has a crappy libpng

chad updated this revision to Diff 32750.Jul 5 2015, 6:35 PM
  • re-optimize
chad mentioned this in T8755: Rebuild Lato / Roboto Slab fonts packs.Jul 5 2015, 6:45 PM
epriestley accepted this revision.Jul 5 2015, 7:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2015, 7:19 PM
Closed by commit rP0cd5031ada4e: Add hidpi media query for mozilla browsers (authored by chad, committed by chad). · Explain WhyJul 5 2015, 7:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32749

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/manifest/login.json

Loading...
View Options

resources/sprite/manifest/menu.json

Loading...
View Options

resources/sprite/manifest/projects.json

Loading...
View Options

resources/sprite/manifest/tokens.json

Loading...
View Options

src/applications/celerity/CeleritySpriteGenerator.php

Loading...
View Options

webroot/rsrc/css/sprite-login.css

Loading...
View Options

webroot/rsrc/css/sprite-menu.css

Loading...
View Options

webroot/rsrc/css/sprite-projects.css

Loading...
View Options

webroot/rsrc/css/sprite-tokens.css

Loading...
View Options

webroot/rsrc/image/sprite-login-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-login.png

Loading...
View Options

webroot/rsrc/image/sprite-menu-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-menu.png

Loading...
View Options

webroot/rsrc/image/sprite-projects-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-projects.png

Loading...
View Options

webroot/rsrc/image/sprite-tokens-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-tokens.png

Loading...
Phabricator · Built by Phacility