Added a "View More" link to the day cell of Calendar monthly view for days with 15 or more events
AbandonedPublic
Actions

Authored by epriestley on Jul 2 2015, 10:19 PM.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

Implements T8361

Test Plan

Add 15 events, all scheduled for a single day. Verify that a "View More" link exists and leads to the daily view for that day.

Repository

rP Phabricator

Branch

calendarseemorelink

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7258
Build 16854: Run Core Tests
Build 7556: [Placeholder Plan] Wait for 30 Seconds

SalmonKiller retitled this revision from to Added a "View More" link to the day cell of Calendar monthly view for days with 15 or more events.

SalmonKiller updated this object.

SalmonKiller edited the test plan for this revision. (Show Details)

src/view/phui/calendar/PHUICalendarMonthView.php
197	Convention dictates that `'a'` should be on its own line.

src/view/phui/calendar/PHUICalendarMonthView.php
199	pht this string

Implemented changes suggested by lpriestley and chad

lpriestley requested changes to this revision.Nov 5 2015, 5:08 PM

lpriestley edited edge metadata.

lpriestley added inline comments.

src/view/phui/calendar/PHUICalendarMonthView.php
197–201	This link doesn't actually have an associated href. When testing this might not give you a problem because the entire cell is clickable, but to be thorough, we should add the correct href to the link. We already have it in the variable `$uri`.
webroot/rsrc/css/phui/calendar/phui-calendar-month.css
214–219	You can see in F945724 that the "View More" link overlaps the week number in the lower left corner of the day box. Maybe you can try removing the `position: absolute;` and explicitly setting `padding-left` to something like 5px. Or if you can think of another solution that might work, certainly give it a shot.