Page MenuHomePhabricator

Don't put objects into the query workspace by default

Authored by epriestley on Jul 1 2015, 6:10 PM.



Ref T8731. I think the issue is that some ProjectQuery (without needImages()) populates the query workspace, then the "real" one hits the workspace.

Instead, only populate the workspace from ObjectQuery, so we know that objects in the workspace always have whatever ObjectQuery attaches to them.

Test Plan

Verified this didn't destroy the cache hitrate, but I can't repro the original issue locally per se.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 32676.Jul 1 2015, 6:10 PM
epriestley retitled this revision from to Don't put objects into the query workspace by default.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Jul 1 2015, 7:58 PM
btrahan edited edge metadata.


This revision is now accepted and ready to land.Jul 1 2015, 7:58 PM
This revision was automatically updated to reflect the committed changes.