[Redesign] Add color to diff Table of Contents
ClosedPublic
Actions

Authored by chad on Jul 1 2015, 2:56 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rP66afb92fb3b0: [Redesign] Add color to diff Table of Contents

Summary

Ref T8099. I think these colors make sense, but if any seem wrong, lmk. Colors the type of file change.

Test Plan

Test a few diffs locally, read carefully, ask epriestley.

Diff Detail

Repository

rP Phabricator

Branch

diff-content-colors

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7081
Build 7214: [Placeholder Plan] Wait for 30 Seconds
Build 7213: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32657.Jul 1 2015, 2:56 AM

chad retitled this revision from to [Redesign] Add color to diff Table of Contents.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 1 2015, 2:56 AM

epriestley accepted this revision.Jul 1 2015, 6:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 1 2015, 6:31 PM

Closed by commit rP66afb92fb3b0: [Redesign] Add color to diff Table of Contents (authored by chad, committed by chad). · Explain WhyJul 1 2015, 6:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

constants/

DifferentialChangeType.php

16 lines

view/

DifferentialDiffTableOfContentsView.php

4 lines

Diff 32657

View Options

src/applications/differential/constants/DifferentialChangeType.php