Page MenuHomePhabricator
Differential D13475

[Redesign] Update Inline Comment UI
ClosedPublic
Actions

Authored by chad on Jun 29 2015, 9:38 PM.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP6fef37ddb5b5: [Redesign] Update Inline Comment UI
Summary

Ref T8099, Simplifies the button bar with a borderless option and implements in Differential Inline Commenting.

Test Plan

Review new and old comments, submitted, unsubmitted, ghosts, done.

pasted_file (232×575 px, 36 KB)

Diff Detail

Repository
rP Phabricator
Branch
button-bar
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7050
Build 7153: [Placeholder Plan] Wait for 30 Seconds
Build 7152: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32610.Jun 29 2015, 9:38 PM
chad retitled this revision from to [Redesign] Update Inline Comment UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 29 2015, 9:38 PM
chad edited the test plan for this revision. (Show Details)Jun 29 2015, 9:40 PM
epriestley accepted this revision.Jun 29 2015, 9:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2015, 9:41 PM
Closed by commit rP6fef37ddb5b5: [Redesign] Update Inline Comment UI (authored by chad, committed by chad). · Explain WhyJun 29 2015, 9:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
uiexample/
examples/
21 lines
infrastructure/
diff/
view/
15 lines
view/
phui/
13 lines
webroot/
rsrc/
css/
application/
differential/
71 lines
phui/
29 lines

Diff 32610

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIButtonBarExample.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

src/view/phui/PHUIButtonBarView.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
Phabricator · Built by Phacility