Page MenuHomePhabricator
Differential D13422

Return `$this` from setter methods
ClosedPublic
Actions

Authored by joshuaspence on Jun 25 2015, 8:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:40 PM
Unknown Object (File)
Sat, Dec 14, 4:57 PM
Unknown Object (File)
Wed, Dec 11, 9:47 AM
Unknown Object (File)
Wed, Dec 11, 8:00 AM
Unknown Object (File)
Mon, Dec 9, 12:28 AM
Unknown Object (File)
Sat, Dec 7, 1:44 AM
Unknown Object (File)
Tue, Dec 3, 4:15 PM
Unknown Object (File)
Fri, Nov 29, 3:26 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPf2435fd1d0b5: Return `$this` from setter methods
Summary

Return $this from setter methods for consistency. I started writing a linter rule to detect this, but I don't think it is trivial to do this properly.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6988
Build 7033: [Placeholder Plan] Wait for 30 Seconds
Build 7032: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32504.Jun 25 2015, 8:34 AM
joshuaspence retitled this revision from to Return `$this` from setter methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 25 2015, 8:34 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence mentioned this in D13423: Return `$this` from setter methods.Jun 25 2015, 8:38 AM
joshuaspence updated this object.
joshuaspence edited edge metadata.
joshuaspence updated this object.Jun 25 2015, 9:16 AM
joshuaspence mentioned this in rARC5466451b76cd: Return `$this` from setter methods.Jun 25 2015, 12:31 PM
epriestley accepted this revision.Jun 25 2015, 10:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 10:58 PM
Closed by commit rPf2435fd1d0b5: Return `$this` from setter methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 6 2015, 12:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
aphlict/
management/
1 line
differential/
parser/
1 line
diviner/
atom/
1 line
legalpad/
editor/
1 line
metamta/
view/
1 line
paste/
view/
1 line
releeph/
editor/
2 lines
field/
specification/
1 line
1 line
repository/
engine/
2 lines
search/
engine/
2 lines
infrastructure/
customfield/
standard/
1 line

Diff 32504

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/diviner/atom/DivinerAtom.php

Loading...
View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...
View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Loading...
View Options

src/applications/paste/view/PasteEmbedView.php

Loading...
View Options

src/applications/releeph/editor/ReleephRequestTransactionalEditor.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephFieldSpecification.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
Phabricator · Built by Phacility