Minor tidying of PhutilSymbolLoader
ClosedPublic
Actions

Authored by joshuaspence on Jun 21 2015, 2:57 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU6fedd82a29a0: Minor tidying of PhutilSymbolLoader

Summary

Minor improvements to the documentation of PhutilSymbolLoader.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32376.Jun 21 2015, 2:57 AM

joshuaspence retitled this revision from to Minor tidying of PhutilSymbolLoader.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 21 2015, 2:57 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 21 2015, 10:55 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 21 2015, 10:55 AM

joshuaspence added inline comments.Jun 21 2015, 9:59 PM

src/symbols/PhutilSymbolLoader.php
35–37	As a side note, we could potentially formalize this with an `@no-phutil` annotation.

Closed by commit rPHU6fedd82a29a0: Minor tidying of PhutilSymbolLoader (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 21 2015, 9:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

symbols/

PhutilSymbolLoader.php

59 lines

Diff 32398

View Options

src/symbols/PhutilSymbolLoader.php

Minor tidying of PhutilSymbolLoaderClosedPublicActions