Page MenuHomePhabricator

[Redesign] Darken things when dark header is used

Authored by chad on Jun 19 2015, 9:13 PM.



Ref T8099, uses original bgcolor when dark headers are used.

Test Plan

Switch between light and dark Phabricator, see new colors.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

chad retitled this revision from to [Redesign] Darken things when dark header is used.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.

I can just give you post-processing for CSS so you can theme the {$color} variables, is that preferable to this?

Particularly, I don't think we should produce "okay for everyone but kind of sucky for everyone too" -- given that we have groups of users with wildly different visual constraints, we're better off catering to them individually with extreme, targeted color schemes that emphasize legibility. It's not too much work on my end, I can throw something up shortly.

(If you want this on its own since it works better with the dark headers, rather than as a compromise to placate the masses, that's fine too.)

I think based on other feedback, this was worth having something I can toggle on and off with given the 'too bright' feedback. But obviously I'd be happy with user-selectable CSS packages, too. I think we have a good PHUI base to do some interesting things (like dark diffs).

I think I have a reasonable way to do the color theming, give me a bit and I'll see if it's really way harder than I think.

Yeah, I think I still want this. Mostly, those who want the classic header, would likely also want the classic contrast. This is pretty minimal to support and it goes away if we drop header-colors anyways.

chad edited edge metadata.
  • Add Blindigo style, make default for testing

Blindigo is my backup style. I forgot I intentionally called this phui-theme so different treatments could be explored before final cutover.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2015, 12:09 PM
This revision was automatically updated to reflect the committed changes.