Page MenuHomePhabricator
Differential D13310

[Redesign] Fix alignment of icon/grip on ObjectList
ClosedPublic
Actions

Authored by chad on Jun 16 2015, 7:25 PM.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP3846a009162f: [Redesign] Fix alignment of icon/grip on ObjectList
Summary

Ref T8099, these should sit in a 4px gutter.

Also:

  • remove bad route on feed
  • Fix issue with custom logos
  • Fix unit error
Test Plan

Review on dashboards and on Maniphest homepage

Diff Detail

Repository
rP Phabricator
Branch
obj-list-touchups
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6808
Build 6830: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 32206.Jun 16 2015, 7:25 PM
chad retitled this revision from to [Redesign] Fix alignment of icon/grip on ObjectList.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2015, 7:25 PM
epriestley accepted this revision.Jun 16 2015, 8:09 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 8:09 PM
Closed by commit rP3846a009162f: [Redesign] Fix alignment of icon/grip on ObjectList (authored by chad, committed by epriestley). · Explain WhyJun 16 2015, 8:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
conpherence/
controller/
2 lines
people/
application/
2 lines
view/
page/
menu/
12 lines
webroot/
rsrc/
css/
phui/
3 lines

Diff 32206

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...
View Options

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility