Differential D13308

[Redesign] Persisent an open form when actively running queries
ClosedPublic
Actions

Authored by chad on Jun 16 2015, 5:38 PM.

Tags

None

Referenced Files

	F13992417: D13308.diff
	Tue, Oct 22, 4:28 PM

	F13988840: D13308.id32204.diff
	Mon, Oct 21, 4:17 PM

	Unknown Object (File)
	Sun, Oct 13, 4:08 AM

	Unknown Object (File)
	Aug 31 2024, 11:39 AM

	Unknown Object (File)
	Aug 29 2024, 6:52 AM

	Unknown Object (File)
	Aug 28 2024, 11:31 PM

	Unknown Object (File)
	Aug 26 2024, 4:35 PM

	Unknown Object (File)
	Aug 26 2024, 4:24 PM

Subscribers

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rP13e959286c63: [Redesign] Persisent an open form when actively running queries

Summary

Ref T8099, Adds ability to set hidden form open, which leaves form open on searches and moves anchor point.

Test Plan

Run saved searches, advanced searches, and searches from main search ui.

Diff Detail

Repository

Branch

persistent-adv-search

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6806
Build 6828: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	810 ms	PhabricatorLibraryTestCase::testMethodVisibility
	0 ms	PhabricatorAphrontViewTestCase::testHasChildren
	161 ms	PhabricatorCelerityTestCase::testCelerityMaps
	7 ms	PhabricatorConduitTestCase::testConduitMethods
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled
		View Full Test Results (1 Failed · 11 Passed)

Event Timeline

chad updated this revision to Diff 32203.Jun 16 2015, 5:38 PM

chad retitled this revision from to [Redesign] Persisent an open form when actively running queries.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2015, 5:38 PM

whats up with the headers here? it doesn't look like my sandbox.

Fix a mobile header alignment

epriestley accepted this revision.Jun 16 2015, 8:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2015, 8:10 PM

Closed by commit rP13e959286c63: [Redesign] Persisent an open form when actively running queries (authored by chad, committed by epriestley). · Explain WhyJun 16 2015, 8:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

applications/

search/

controller/

PhabricatorApplicationSearchController.php

3 lines

view/

phui/

PHUIObjectBoxView.php

14 lines

webroot/

rsrc/

css/

application/

search/

search-results.css

1 line

phui/

phui-header-view.css

5 lines

Diff 32204

resources/celerity/map.php

Loading...

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...

src/view/phui/PHUIObjectBoxView.php

Loading...

webroot/rsrc/css/application/search/search-results.css

Loading...

webroot/rsrc/css/phui/phui-header-view.css

Loading...